Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: upgrade etcd to v3.4.30 (#7884) #7888

Merged
merged 1 commit into from
Mar 12, 2024
Merged

*: upgrade etcd to v3.4.30 (#7884) #7888

merged 1 commit into from
Mar 12, 2024

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Mar 7, 2024 •
edited by JmPotato
Loading

This is an automated cherry-pick of #7884

What problem does this PR solve?

Issue Number: close #7904, ref #5520.

What is changed and how does it work?

Upgrade etcd to v3.4.30 and adopt the latest code changes.

Check List

Tests

  • Unit test
  • Integration test

Release note

Upgrade etcd to v3.4.30 to adopt the security patch.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 7, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 7, 2024
Merged
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 7, 2024 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. label Mar 7, 2024
@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and nolouch March 7, 2024 03:49
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 7, 2024
@JmPotato JmPotato force-pushed the cherry-pick-7884-to-release-7.5 branch from 420c54b to 8c314ae Compare March 7, 2024 04:08
@JmPotato
Upgrade etcd to v3.4.30
2cad730 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato force-pushed the cherry-pick-7884-to-release-7.5 branch from 8c314ae to 2cad730 Compare March 7, 2024 04:10
@codecov Codecov
Copy link

codecov bot commented Mar 7, 2024 •
edited
Loading

Codecov Report

Merging #7888 (2cad730) into release-7.5 (3488a65) will decrease coverage by 0.04%.
Report is 2 commits behind head on release-7.5.
The diff coverage is 100.00%.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-7.5    #7888      +/-   ##
===============================================
- Coverage        74.53%   74.50%   -0.04%     
===============================================
  Files              444      444              
  Lines            48140    48154      +14     
===============================================
- Hits             35882    35876       -6     
- Misses            9073     9083      +10     
- Partials          3185     3195      +10
Flag Coverage Δ
unittests 74.50% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 7, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 11, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 12, 2024
@JmPotato
Copy link
Member

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 12, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 12, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 2cad730

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 12, 2024
@ti-chi-bot ti-chi-bot bot merged commit 8544834 into tikv:release-7.5 Mar 12, 2024
23 of 24 checks passed
@JmPotato JmPotato deleted the cherry-pick-7884-to-release-7.5 branch March 12, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@nolouch nolouch nolouch approved these changes

@lhy1024 lhy1024 Awaiting requested review from lhy1024

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @JmPotato @nolouch @rleungx